This repository was archived by the owner on Nov 19, 2024. It is now read-only.
fix: update @trpc/server imports to use dist#411
Open
mckelveygreg wants to merge 1 commit intotrpc:masterfrom
Open
fix: update @trpc/server imports to use dist#411mckelveygreg wants to merge 1 commit intotrpc:masterfrom
mckelveygreg wants to merge 1 commit intotrpc:masterfrom
Conversation
TRPC ships with its src ts files and these sneaky imports were accidentally targeting that ts, and not the dist files, making it so the whole trpc lib was getting checked by the consumers tsc build! In particular, this surfaced for me because my project has verbatimModuleSyntax set to true, and trpc does not lean on that option.
|
Thanks for the fix @mckelveygreg ! I got a similar issue here https://github.com/useVenice/venice/actions/runs/6516455413 and confirm monkey patching fixes it too |
Closed
|
This also fixes problems encountered in #335 |
|
Thank you for this! @jlalmes come on, this is as an easy and essential one to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRPC ships with its src .ts files. There are sneaky imports in this lib that were accidentally targeting TRPC ts, and not the dist files, making it so the whole
@trpc/serverlib was getting checked by the consumer's tsc build!In particular, this surfaced for me because my project has
verbatimModuleSyntaxset totrue, and trpc does not lean on that option.Thanks for this nifty lib and let me know how else I can help
For anyone else coming across this, you can monkey patch with yarn until it gets shipped: https://yarnpkg.com/cli/patch