Type mods2 - #79
Merged
Merged
Conversation
Distinguish between type and class dummy arguments
Allow either a class or type to be added to a linked list iterator,
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 94.58% 93.67% -0.91%
==========================================
Files 32 31 -1
Lines 2860 2957 +97
==========================================
+ Hits 2705 2770 +65
- Misses 155 187 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Increase coverage on linked list class
This was referenced Jul 27, 2026
Closed
Remove asn unneeded class version in FTDictionaryClass. Add test for class version of release in MultiIndexTable
cover unused add null to iterator
Make a change to test HOHQMesh ifx error
Put deallocation back in
Add TODO on location of problem with ifx compiler.
Restore FTMultableObjectArray deallocation procedure. Plus, found a bug where if a linked list didn't have any items in it, it's status as circular or not could be changed.
Now distinguishes between objects defined by TYPE and those defined by CLASS
Add news about Class/type distinction
andrewwinters5000
requested changes
Jul 29, 2026
andrewwinters5000
left a comment
andrewwinters5000
left a comment
Member
There was a problem hiding this comment.
The changes look good with the new releaseXXClass versions of the routines. I only left one question about some commented code.
| IF(.NOT.ASSOCIATED(obj)) self => NULL() | ||
| END SUBROUTINE releaseFTKeyObjectPair | ||
| !! | ||
| !!//////////////////////////////////////////////////////////////////////// |
Member
There was a problem hiding this comment.
Should this routine be removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version creates options for working with type defined and class defined pointers.