Repository navigation
The licence notices are made when the app is packaged, not kept in the repository - #15
Merged
Merged
Conversation
…t in the repository THIRD_PARTY_NOTICES.md is a generated list of the 280 packages bundled into the app. The licences of what is bundled ask for it to travel with the app, so it stays in the app (Help, Licences of the Software Lucid Uses), but it does not have to sit in the repository root and be kept up to date by a CI check. `prepack` now writes it, and afterPack still refuses an app without it. The script runs pnpm from the repository root, and through a shell on Windows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question
Is
THIRD_PARTY_NOTICES.mdneeded? It is a generated list of the 280 packages bundled into the app, with their licences, and a CI check kept it up to date.Answer
It cannot simply go: the licences of what the app bundles (MIT, BSD, Apache, and MPL-2.0 for BlockNote, EPL-2.0 for elkjs) ask for their notices to travel with the app that is handed out. But it does not need to live in the repository root and be maintained by hand.
What changes
prepack(scripts/notices.mjs) and is git-ignored. It still ships in the app (Help, "Licences of the Software Lucid Uses"), andafterPackand the packaged-app test still refuse an app without it.prepack) and through a shell on Windows. This PR touches packaging, so the Release workflow builds and tests it on macOS, Windows and Linux.🤖 Generated with Claude Code