fix(sdk): resolve ReferenceError in envvars.update() outside task con… - #4920
fix(sdk): resolve ReferenceError in envvars.update() outside task con…#4920mahenoorsalat wants to merge 1 commit into
Conversation
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
WalkthroughThe change adds validation for the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @mahenoorsalat, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (typeof nameOrRequestOptions !== "string") { | ||
| throw new Error("name is required"); | ||
| } |
There was a problem hiding this comment.
🟡 Empty variable names bypass validation
An empty nameOrRequestOptions passes validation and sends update to an endpoint without a variable name. The update fails as an HTTP routing error.
| if (typeof nameOrRequestOptions !== "string") { | |
| throw new Error("name is required"); | |
| } | |
| if (!nameOrRequestOptions || typeof nameOrRequestOptions !== "string") { | |
| throw new Error("name is required"); | |
| } |
Was this helpful? React with 👍 or 👎 to provide feedback.
| if (typeof nameOrRequestOptions !== "string") { | ||
| throw new Error("name is required"); | ||
| } | ||
|
|
||
| if (!params) { | ||
| throw new Error("params is required"); | ||
| } | ||
|
|
||
| $projectRef = projectRefOrName; | ||
| $slug = slugOrParams; | ||
| $name = name!; | ||
| $name = nameOrRequestOptions; |
There was a problem hiding this comment.
🔍 SDK fix lacks a changeset
This user-visible @trigger.dev/sdk runtime fix has no changeset. Repository guidance requires release notes for package bugs customers can encounter.
Was this helpful? React with 👍 or 👎 to provide feedback.
| globalThis.fetch = (async (input: any, init?: RequestInit) => { | ||
| const url = typeof input === "string" ? input : (input?.url ?? String(input)); | ||
| const headers = new Headers(init?.headers); | ||
| captured.push({ | ||
| url, | ||
| method: init?.method, | ||
| authorization: headers.get("authorization") ?? undefined, | ||
| body: typeof init?.body === "string" ? init.body : undefined, | ||
| }); | ||
| return new Response( | ||
| JSON.stringify({ | ||
| name: "DATABASE_URL", | ||
| value: "postgres://...", | ||
| }), | ||
| { | ||
| status: 200, | ||
| headers: { "content-type": "application/json" }, | ||
| } | ||
| ); | ||
| }) as typeof fetch; |
There was a problem hiding this comment.
🔍 Test mocks global fetch
The test replaces globalThis.fetch with a custom implementation. Repository guidance prohibits mocks and requires real test infrastructure.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
…text (#4264)
Closes #
✅ Checklist
Testing
[Describe the steps you took to test this change]
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
💯