test(observability-map): name the environment on the queues page failure logs - #4485
test(observability-map): name the environment on the queues page failure logs#44851stvamp wants to merge 4 commits into
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Observability mapAs of Nothing in this pull request moves the report any more. The findings an earlier push reported are gone. Report only, nothing here gates the merge. The rules and their reasons: internal-packages/observability-map/README.md. |
a681f21 to
1cd8d80
Compare
7ee2a98 to
05e9507
Compare
…ure logs Throwaway PR to verify the observability-map CI comment reports an improvement. Not for merge.
1cd8d80 to
d3ce17d
Compare
27cf0b0 to
6d9c167
Compare
Reverts the route edit and touches a non-route file, so the diff is non-empty but matches neither watched path while a findings comment exists. Tests that the workflow still starts and reconciles the comment.
|
Test complete. All four states of the delta rule confirmed on the real runner, plus the stale-comment gap this exposed (fixed in 042c9c3) and its reconcile path. Closing; branch deleted. |
Throwaway. Case 1 of 3 in an end-to-end check of the observability-map CI
comment: a real improvement should be reported as one.
The two logger.warn calls on the queues page log { error } with no tenant,
while environment is already in scope. Adding environmentId is exactly the
change the tool asks for.
Locally verified: that route goes 0 -> 50, request-context fail -> pass.
Global stays 19, because one route in 412 cannot move the rounded mean.
Do not merge. Will be closed once the CI behaviour is observed.
This is part 4 of 4 in a stack made with GitButler: