Skip to content

fix(cli): disable OTel in depot child to prevent OTEL_EXPORTER_OTLP_ENDPOINT build failures #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eeshsaxena wants to merge 1 commit into from
+7 −0
Closed

fix(cli): disable OTel in depot child to prevent OTEL_EXPORTER_OTLP_ENDPOINT build failures #4370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/cli-v3/src/deploy/buildImage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,13 @@ async function remoteBuildImage(options: DepotBuildImageOptions): Promise<BuildI
DEPOT_PROJECT_ID: options.buildProjectId,
DEPOT_NO_SUMMARY_LINK: "1",
DEPOT_NO_UPDATE_NOTIFIER: "1",
// Prevent ambient OTEL env vars (e.g. OTEL_EXPORTER_OTLP_ENDPOINT) from
// leaking into the depot child process. The depot CLI initialises its own
// OTel exporter and fails during telemetry init when it inherits an
// endpoint it can't reach — silently killing the build with a misleading
// "Error building image" message. See: triggerdotdev/trigger.dev#4321
OTEL_SDK_DISABLED: "1",
OTEL_EXPORTER_OTLP_ENDPOINT: "",
Comment on lines +264 to +265

@devin-ai-integration devin-ai-integration Bot Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Change to a published package is missing its release-notes entry

This change updates the published CLI package (packages/cli-v3/src/deploy/buildImage.ts:259-265) but no changeset was added to the pull request, so the fix will not be versioned or appear in user-visible release notes.
Impact: The bug fix ships without a version bump or changelog entry, so users won't see it in release notes and the package version won't be updated.

Missing changeset for a public package change

AGENTS.md states: "When modifying any public package (packages/* or integrations/*), add a changeset" via pnpm run changeset:add, and CONTRIBUTING.md states that PRs touching /packages "will need to add a changeset to your Pull Requests before they can be merged." packages/cli-v3 is the published trigger.dev package. The PR's only diff is in packages/cli-v3/src/deploy/buildImage.ts and no file was added under .changeset/.

Prompt for agents 
This PR modifies the published package packages/cli-v3 (trigger.dev on npm) but does not include a changeset. Per AGENTS.md and CONTRIBUTING.md, any change to a public package under packages/* requires a changeset. Run pnpm run changeset:add and create a patch changeset describing the fix for users (e.g. that deploying no longer fails when OTEL_EXPORTER_OTLP_ENDPOINT is present in the shell environment). Write the description for users, not maintainers, and avoid naming internal tools/infra.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

},
});

Expand Down