fix(webapp): strip secure param from query ClickHouse URL#3199
fix(webapp): strip secure param from query ClickHouse URL#3199edosrecki wants to merge 1 commit intotriggerdotdev:mainfrom
Conversation
The `initializeQueryClickhouseClient()` function was missing the
`url.searchParams.delete("secure")` call that the other two sibling
ClickHouse client init functions already had. This caused a startup
crash (`Error: Unknown URL parameters: secure`) when QUERY_CLICKHOUSE_URL
fell back to CLICKHOUSE_URL which contains `?secure=false`.
Fixes triggerdotdev#3184
|
|
Hi @edosrecki, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe pull request adds a fix that removes the "secure" query parameter from ClickHouse URL environment variables before client instantiation. This resolves startup errors caused by unknown URL parameters in the ClickHouse client initialization. The fix is applied consistently across multiple ClickHouse client initializations (query and logs clients) and is documented via a changelog entry. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
Summary
initializeQueryClickhouseClient()function inclickhouseInstance.server.tswas missing theurl.searchParams.delete("secure")call that the other two sibling ClickHouse client init functions (initializeClickhouseClientandinitializeLogsClickhouseClient) already hadError: Unknown URL parameters: securewhenQUERY_CLICKHOUSE_URLfell back toCLICKHOUSE_URL(which contains?secure=false)Fixes #3184