test(webapp): cover unselected billing limit mode and default alerts

Author: kathiekiwi

.server-changes/billing-limit-unconfigured-ux.md

@@ -0,0 +1,6 @@
+---
+area: webapp
+type: improvement
+---
+
+The billing limit page no longer pre-selects an option before you've configured a limit, and shows a clear prompt to set one up. The reminder banner is now hidden for members who can't manage billing.

apps/webapp/test/billingAlertsDefaults.test.ts

@@ -0,0 +1,26 @@
+import { describe, expect, it } from "vitest";
+import { buildDefaultBillingAlerts } from "~/services/billingAlertsDefaults.server";
+import { ABSOLUTE_ALERT_BASE_CENTS } from "~/components/billing/billingAlertsFormat";
+
+describe("buildDefaultBillingAlerts", () => {
+  it("uses the absolute dollar base so alert levels read as dollar thresholds", () => {
+    expect(buildDefaultBillingAlerts().amount).toBe(ABSOLUTE_ALERT_BASE_CENTS);
+    expect(buildDefaultBillingAlerts().amount).toBe(100);
+  });
+
+  it("starts with no recipients so the platform falls back to org members", () => {
+    expect(buildDefaultBillingAlerts().emails).toEqual([]);
+  });
+
+  it("seeds the default dollar alert thresholds", () => {
+    expect(buildDefaultBillingAlerts().alertLevels).toEqual([5, 100, 500, 1000, 2500]);
+  });
+
+  it("returns a fresh alertLevels array each call (no shared mutable state)", () => {
+    const first = buildDefaultBillingAlerts();
+    const second = buildDefaultBillingAlerts();
+    expect(first.alertLevels).not.toBe(second.alertLevels);
+    first.alertLevels.push(9999);
+    expect(second.alertLevels).toEqual([5, 100, 500, 1000, 2500]);
+  });
+});

apps/webapp/test/billingLimitsRoute.test.ts

@@ -266,6 +266,27 @@ describe("isBillingLimitFormDirty", () => {
     gracePeriodMs: 86_400_000,
   };
 
+  it("is not dirty when no mode is selected, regardless of other inputs", () => {
+    expect(
+      isBillingLimitFormDirty({
+        billingLimit: unconfiguredLimit,
+        mode: "",
+        customAmount: "999.00",
+        cancelInProgressRuns: true,
+      })
+    ).toBe(false);
+
+    // Even a configured limit stays clean while the form has no selection.
+    expect(
+      isBillingLimitFormDirty({
+        billingLimit: configuredPlanLimit,
+        mode: "",
+        customAmount: "50.00",
+        cancelInProgressRuns: true,
+      })
+    ).toBe(false);
+  });
+
   it("is dirty when billing limit has never been saved", () => {
     expect(
       isBillingLimitFormDirty({
@@ -277,6 +298,26 @@ describe("isBillingLimitFormDirty", () => {
     ).toBe(true);
   });
 
+  it("is dirty when an unconfigured limit picks a real mode (initial save)", () => {
+    expect(
+      isBillingLimitFormDirty({
+        billingLimit: unconfiguredLimit,
+        mode: "plan",
+        customAmount: "",
+        cancelInProgressRuns: false,
+      })
+    ).toBe(true);
+
+    expect(
+      isBillingLimitFormDirty({
+        billingLimit: unconfiguredLimit,
+        mode: "custom",
+        customAmount: "100.00",
+        cancelInProgressRuns: false,
+      })
+    ).toBe(true);
+  });
+
   it("is clean when configured values match saved state", () => {
     expect(
       isBillingLimitFormDirty({