chore(webapp): drop billing alerts backfill machinery in favor of billing-side migration

Author: kathiekiwi

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx

@@ -24,10 +24,6 @@ import {
   thresholdValuesAreUnique,
 } from "~/components/billing/billingAlertsFormat";
 import { getSuggestedRecoveryLimitDollars } from "~/components/billing/billingLimitFormat";
-import {
-  billingAlertsLookUnconfigured,
-  buildDefaultBillingAlerts,
-} from "~/services/billingAlertsDefaults.server";
 import {
   BillingLimitConfigSection,
   billingLimitFormSchema,
@@ -130,25 +126,15 @@ export const loader = dashboardLoader(
       });
     }
 
-    const planLimitCents = currentPlan?.v3Subscription?.plan?.limits.includedUsage ?? 500;
-
-    const [alertsError, fetchedAlerts] = await tryCatch(getBillingAlerts(organization.id));
-    let alerts = alertsError ? undefined : fetchedAlerts;
-    if (
-      getBillingLimitMode(billingLimit) === "none" &&
-      (!alerts || billingAlertsLookUnconfigured(alerts))
-    ) {
-      // Lazily seed default alerts for orgs that have none configured.
-      const defaults = buildDefaultBillingAlerts();
-      const [seedError, seeded] = await tryCatch(setBillingAlert(organization.id, defaults));
-      alerts = seedError || !seeded ? defaults : seeded;
-    }
-    if (!alerts) {
+    const [alertsError, alerts] = await tryCatch(getBillingAlerts(organization.id));
+    if (alertsError || !alerts) {
       throw new Response(null, {
         status: 404,
         statusText: `Billing alerts error: ${alertsError ?? "not found"}`,
       });
     }
+
+    const planLimitCents = currentPlan?.v3Subscription?.plan?.limits.includedUsage ?? 500;
     const alertsResetRequested = getAlertsResetRequested(request);
     const resolveSubmitted = getResolveSubmitted(request);
     const submittedResumeMode = getSubmittedResumeMode(request);

apps/webapp/app/routes/admin.api.v1.billing-alerts.backfill.ts

@@ -21,21 +21,3 @@ export function buildDefaultBillingAlerts(): UpdateBillingAlertsRequest {
     alertLevels: [...DEFAULT_ALERT_THRESHOLD_DOLLARS],
   };
 }
-
-/**
- * Whether alerts look never-configured. When no alert row exists the platform
- * returns a default of `{ amount: planIncludedUsage, emails: [], alertLevels: [] }`;
- * a deliberately cleared config stores the $1 absolute base amount and/or keeps
- * the configured emails.
- */
-export function billingAlertsLookUnconfigured(alerts: {
-  amount: number;
-  emails: string[];
-  alertLevels: number[];
-}): boolean {
-  return (
-    alerts.alertLevels.length === 0 &&
-    alerts.emails.length === 0 &&
-    alerts.amount !== ABSOLUTE_ALERT_BASE_CENTS
-  );
-}