Skip to content

chore: pre-publish fixes from review#2

Merged
ericallam merged 1 commit intomainfrom
chore/pre-publish-fixes
Mar 10, 2026
Merged

chore: pre-publish fixes from review#2
ericallam merged 1 commit intomainfrom
chore/pre-publish-fixes

Conversation

@ericallam
Copy link
Member

Summary

Fixes from the 3-agent review (docs messaging, API surface, skill token efficiency).

  • README: 489 to 184 lines. API reference replaced with summary table + docs link.
  • Core skill: 307 to 166 lines. Removed README-duplicated content. Common Mistakes preserved.
  • Exports: Removed deprecated SocketSink. Added ./test export for MemorySink.
  • Collector /health: Returns JSON with status, port, store path, active session.
  • tail: Creates crumb file and waits instead of exiting on missing file.
  • Agent workflow: agentcrumbs clear before reproduce pattern (no --since guessing).
  • CLI args: Deduplicated getFlag into shared src/cli/args.ts.
  • Transport: Renamed socket.ts to http.ts.

Test plan

  • pnpm build compiles cleanly
  • agentcrumbs collect starts, /health returns JSON
  • agentcrumbs tail creates file and waits when no crumb file exists
  • agentcrumbs clear works while collector is running
  • import { MemorySink } from "agentcrumbs/test" resolves

README:
- Slimmed from 489 to 184 lines (62% cut)
- Full API reference replaced with table + docs link
- Crumb markers, node_modules, PR reviewer sections moved to docs only

Skills:
- Core skill trimmed from 307 to 166 lines (46% cut)
- Removed content duplicated from README (workflow, env var, noop)
- All Common Mistakes sections preserved

Exports:
- Removed deprecated SocketSink alias
- Added ./test conditional export for MemorySink
- Renamed transport/socket.ts to transport/http.ts

Collector:
- /health endpoint now returns JSON (status, port, store, session)
- tail command creates crumb file instead of hard-failing on missing file
- Agent workflow: clear before reproduce (no --since guessing)

CLI:
- Deduplicated getFlag into shared src/cli/args.ts
- All 5 commands import from shared utility
@ericallam ericallam merged commit 1174776 into main Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants