-
Notifications
You must be signed in to change notification settings - Fork 0
Add OpenTelemetry JVM metrics with Prometheus and Grafana observability stack #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…heus/Grafana support Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
…source lifecycle Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
|
@copilot 1. According the docs there is more simple usage of this library. Try to apply this approach:
|
…nd update to latest library versions Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
I've addressed all three points in commit fb960c5:
The implementation now uses OpenTelemetry's autoconfiguration via environment variables ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements comprehensive JVM runtime metrics collection using OpenTelemetry with Prometheus export and Grafana visualization capabilities. The implementation uses otel4s for Scala integration and provides automatic JVM metrics collection for memory, GC, threads, CPU, and other runtime statistics.
Key changes:
- Integrated OpenTelemetry with automatic configuration and JVM runtime metrics collection
- Added Prometheus and Grafana services to docker-compose for metrics monitoring
- Updated documentation with observability features and access points
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/main/scala/ru/trett/rss/server/Server.scala | Adds OpenTelemetry initialization with runtime metrics registration and proper resource management |
| build.sbt | Adds otel4s and OpenTelemetry runtime metrics dependencies |
| scripts/local-docker/docker-compose.yml | Configures Prometheus and Grafana services with proper environment variables for metrics export |
| scripts/local-docker/prometheus.yml | Defines Prometheus scraping configuration targeting the server metrics endpoint |
| README.md | Documents new observability features and access endpoints |
| client/package-lock.json | Minor npm dependency metadata cleanup |
Files not reviewed (1)
- client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
…, add Grafana provisioning Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Applied all changes from the review in commit 20b6869:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.