Repository navigation
Initialize TOC when file variables enable the extra - #740
Merged
Merged
Conversation
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
use_file_vars=True, a document beginning with<!-- -*- markdown-extras: toc -*- -->crashes while rendering its first heading (UnboundLocalError: header_id). Declaringheader-ids, tocin that file variable instead crashes because_toc_depthwas never set. TOC setup currently runs only for constructor extras, before file variables are read.Change
Run the existing TOC setup when extras are refreshed, so file variables get the same implied heading IDs and depth initialization as constructor extras. Add a regression covering both file-variable forms and repeated conversions with the same
Markdowninstance. Document the TOC file-variable form in the README.Verification
d030ca7f9ef55b73f143450c5835e48f4b5d4043before the fix.py -3.14 testall.pyfromtest/: 289 passed.py test.py -- -knownfailurefromtest/: 289 passed.--use-file-varsCLI rendering emits a TOC and heading ID for the example modeline.git diff --checkand changed-line PEP8 check passed.