Repository navigation
Fix sanitized HTML leaking into header ids in safe mode - #739
Merged
nicholasserra merged 2 commits intoOct 16, 2026
Merged
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
safe_modeand theheader-idsextra, any inline HTML in a header ends up in the generated id. The id is built while the HTML is still hashed, so the hash keys survive slugifying and are later replaced with the sanitized HTML. Since sanitizing doesn't escape quotes, a header like# Hi <b x="a" onmouseover="alert(1)">x</b>in escape mode produces<h1 id="hi-<b x="a" onmouseover="alert(1)">...">, which closes the id early and injects an event handler.This unhashes the HTML spans before generating the id, so the id comes out the same as without safe mode (
hello-bworldbfor# Hello <b>world</b>). In replace mode the placeholder is slugified as well instead of leaving[HTML_REMOVED]in the id.Added test cases for both
escapeandreplacemodes. This also covers the safe mode case mentioned in #649.