Skip to content

fix: nightly macOS Sendable + WinUI PresentationMapper compile - #277

Merged
enricopiovesan merged 1 commit into
mainfrom
cursor/ticket-fix-nightly-native-macos-windows
Aug 26, 2026
Merged

fix: nightly macOS Sendable + WinUI PresentationMapper compile#277
enricopiovesan merged 1 commit into
mainfrom
cursor/ticket-fix-nightly-native-macos-windows

Conversation

@enricopiovesan

Copy link
Copy Markdown
Contributor

Summary

  • Nightly 2026-08-26 required jobs failed: native-macos (Swift 6 Sendable on Any? presentation snapshots) and native-windows (TraverseStarter.Tests compiled EmbeddedHost.cs without PresentationMapper.cs).
  • Mark presentation mapper structs @unchecked Sendable on all four Swift cores (equality already ignores runtime JSON; UI still does not compute title/tags/status).
  • Link PresentationMapper.cs into starter WinUI tests, matching doc-approval / meeting-notes / loop.

Governing Spec

  • Specs 001/002 presentation mapping; public embedder only.
  • No business fields in UI. No sidecar.

Project Item

Definition of Done

  • Four Swift cores Sendable-safe for nightly xcodebuild
  • TraverseStarter.Tests.csproj includes PresentationMapper.cs
  • No sidecar / fake runtime
  • Nightly native-macos + native-windows green after merge (or re-run workflow_dispatch)

Validation

  • cd apps/traverse-starter/TraverseCore && swift testTraverseCore / PresentationMapper.swift compile; remaining test failure is pre-existing errorMessage setter (not this change)
  • dotnet test not run here (NuGet restore failed locally)
  • CI PR gates: repository-checks / quality / coverage-gate / embedded-smoke

Checklist

Traceability

  • Project 2 claimed (Cursor, In Progress)
  • AGENTS.md start-plan row
  • Blocked MCP set unchanged

Production baseline (platform / runtime-client PRs)

  • Embedded mode unchanged
  • No new sidecar URL
  • SDK doubles unchanged
  • Docs: start-plan only
  • Validation listed

Architecture

  • No business logic added to UI layer
  • No private Traverse internals imported

Swift 6 rejects Any? on Sendable presentation structs; mark those snapshots unchecked Sendable (equality already ignores runtime JSON). Link PresentationMapper.cs into TraverseStarter.Tests like the other WinUI shells.

Co-authored-by: Cursor <cursoragent@cursor.com>
@enricopiovesan
enricopiovesan merged commit 40588c0 into main Aug 26, 2026
8 checks passed
@enricopiovesan
enricopiovesan deleted the cursor/ticket-fix-nightly-native-macos-windows branch August 26, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant