Skip to content

Extract doc-approval-core-rs shared HTTP/SSE crate for GTK and CLI#143

Merged
enricopiovesan merged 1 commit into
mainfrom
cursor/issue-73-doc-approval-core-rs
Jul 12, 2026
Merged

Extract doc-approval-core-rs shared HTTP/SSE crate for GTK and CLI#143
enricopiovesan merged 1 commit into
mainfrom
cursor/issue-73-doc-approval-core-rs

Conversation

@enricopiovesan

Copy link
Copy Markdown
Contributor

Summary

  • Add shared apps/doc-approval/doc-approval-core-rs crate (send_command, session-scoped dispatch, list_sessions, SSE subscribe_events, discovery)
  • Introduce apps/doc-approval Cargo workspace; wire linux-gtk and cli-rust path deps
  • Migrate both shells from execute/poll to command dispatch + SSE terminal events

Governing Spec

Project Item

Definition of Done

  • list_sessions(state: Option<&str>) returns typed vec
  • send_command / session-scoped dispatch
  • Unit tests: HTTP construction, SSE parsing, session listing parsing
  • linux-gtk and cli-rust both depend on this crate
  • No GTK or terminal UI imports — platform-neutral

Validation

  • cd apps/doc-approval && cargo test -p doc-approval-core-rs -p doc-approval-cli
  • bash scripts/ci/repository_checks.sh
  • cargo test -p doc-approval-gtk (requires GTK4 sysdeps; not available on this macOS agent host)

Architecture boundary

  • UI shells render runtime fields only; transitions owned by Traverse SSE events
  • Public HTTP/SSE surfaces only

Checklist

  • Issue linked and Project 2 item updated
  • Updated AGENTS.md / README.md Ready summary
  • No business logic added to UI layer
  • CI gates pass locally where applicable

Made with Cursor

linux-gtk and cli-rust now depend on a workspace crate for send_command,
session listing, and SSE events, mirroring traverse-core-rs from #59.

Co-authored-by: Cursor <cursoragent@cursor.com>
@enricopiovesan enricopiovesan enabled auto-merge (squash) July 12, 2026 03:13
@enricopiovesan enricopiovesan merged commit 24d2b89 into main Jul 12, 2026
6 checks passed
@enricopiovesan enricopiovesan deleted the cursor/issue-73-doc-approval-core-rs branch July 12, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract doc-approval-core-rs: shared Rust crate for linux-gtk + cli-rust

1 participant