Sign coverage publish commits#427
Open
kvz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Transloadit verified-commit ruleset now rejects unsigned generated commits. The scheduled CI run on
mainpassed the E2E work, then failed while pushingStatic file updatestotransloadit/node-sdk-coveragebecause the generated commit was unsigned.What changed
COVERAGE_REPO_SIGNING_SSH_KEYsecret for coverage publishing.Transloadit Bot <24697610+transloadit-bot@users.noreply.github.com>.Signing key status
The private half has been stored as the
COVERAGE_REPO_SIGNING_SSH_KEYsecret ontransloadit/node-sdk. The public half has been added totransloadit-botas SSH signing key ID985158.Validation
git diff --checkyarn lint:changesetsyarn lint:publishworkflow_dispatchonsign-coverage: https://github.com/transloadit/node-sdk/actions/runs/27059000861The manual run pushed a verified coverage commit to
transloadit/node-sdk-coverage:main: transloadit/node-sdk-coverage@b104331actionlintis not installed locally. Biome intentionally ignores.github/workflows/ci.ymlin this repo.