⚡ Bolt: optimize ticker discovery hot paths - #117
Conversation
Optimizes the `buildCandidate` and `rsi14` functions in `src/tools/discover.ts` to avoid chaining `.map()`, `.slice()`, and `.reduce()` operations. The metrics are now computed directly from the source arrays using index-based `for` loops, removing intermediate array allocations and reducing garbage collection overhead. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored the
rsi14and volume aggregation logic insrc/tools/discover.tsto use directforloops instead of chaining array methods like.map(),.slice(), and.reduce().🎯 Why: The
buildCandidatefunction is a hot path used to evaluate the entire ticker universe. Creating intermediate arrays for every candidate adds unnecessary garbage collection and memory allocation overhead.📊 Impact: Reduces memory allocations per candidate, improving the overall speed of the ticker discovery tool.
🔬 Measurement: Verified by running
pnpm testandpnpm typecheckto ensure the mathematical outputs are identical and that the changes correctly handle out-of-bounds cases gracefully, matching the original.slice()behavior.PR created automatically by Jules for task 12445644334209806449 started by @toreleon