⚡ Bolt: Optimize array allocations in discover tool - #110
Draft
toreleon wants to merge 11 commits into
Draft
Conversation
Eliminates memory allocation and garbage collection overhead in the ticker discovery hot path by removing chaining array methods (`.map`, `.slice`, `.reduce`). Metrics computation now uses direct indexed `for` loops on the source `bars` array. The `rsi14` function was updated to accept the `bars` array directly instead of a mapped array of primitive numbers. These changes prevent allocating and collecting O(N) temporary arrays for hundreds of candidates on each scan. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Resolves a high-severity vulnerability in the `undici` dependency related to cross-user information disclosure and parse-time crashes via degenerate private cache directives. This is caught by the `pnpm audit` CI check. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What:
Eliminated
.map(),.slice(), and.reduce()allocations inbuildCandidateandrsi14functions insrc/tools/discover.ts. Replaced them with direct indexedforloops that operate in-place on the sourcebarsarray.🎯 Why:
During ticker discovery (
discoverTickers), the system iterates over potentially hundreds of stock candidates, pulling recent OHLCV bars for each. The previous implementation mapped thebarsarray into temporaryclosesandvolsarrays, then used.sliceto create subsets, and.reduceto sum values. This created significant, unnecessary memory allocation and garbage collection churn in a hot path.📊 Impact:
Significantly reduces transient memory pressure and GC pauses during ticker discovery sweeps by operating directly on the fetched time-series data without intermediate array copies.
🔬 Measurement:
Run
pnpm test tests/discover.test.tsandpnpm typecheckto verify the logic is perfectly preserved and no tests are failing.PR created automatically by Jules for task 11703465256289938067 started by @toreleon