Added support for acquisition of data from acquire_decimated#92
Open
kjwcoo wants to merge 1 commit intotoolsforexperiments:mainfrom
Open
Added support for acquisition of data from acquire_decimated#92kjwcoo wants to merge 1 commit intotoolsforexperiments:mainfrom
kjwcoo wants to merge 1 commit intotoolsforexperiments:mainfrom
Conversation
marcosfrenkel
previously approved these changes
Jun 16, 2025
marcosfrenkel
requested changes
Jun 16, 2025
Contributor
marcosfrenkel
left a comment
There was a problem hiding this comment.
2 Things:
- You have a big assumption here that there is only a single
DecimatedVariablein the QICK program, this is not specified nor enforced in the code. I am scared people will try to try to have multiple of them in the same program and the data will get scrambled up. - Could we try having
DecimatedVariablebe a child class ofComplexQICKDataand remove any mention ofDecimatedVariablein in theComplexQICKDatasection of thatelifsection (keep all the logic for each type of dataspec on their own section).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep framework for QICK now supports data acquisition from acquire_decimated.