Skip to content

Answer: 8 Refactor pipes - #1540

Open
jpaberzs wants to merge 1 commit into
tomalaforge:mainfrom
jpaberzs:refactor-pipes
Open

jpaberzs wants to merge 1 commit into
tomalaforge:mainfrom
jpaberzs:refactor-pipes

Conversation

@jpaberzs

@jpaberzs jpaberzs commented Aug 26, 2026

Copy link
Copy Markdown

✅ Challenge Submission Checklist

Start your PR title with: Answer:${challenge_number}

⚠️ Important Notice

If you would like personal feedback or a detailed review, please support the project on GitHub:

You can also submit a PR without sponsorship to:

  • Be listed among the answered challenges, or
  • Receive a review from a community member. 🔥

Summary by CodeRabbit

  • New Features

    • Added formatting that displays each person’s name together with their list index.
    • Introduced reusable formatting for consistent name-and-index presentation.
  • Refactor

    • Replaced inline formatting logic with a dedicated reusable component.
    • Improved type clarity for the displayed person list.

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@jpaberzs is attempting to deploy a commit to the tomalaforge's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b62b7ce8-6ba9-4800-9db8-ea24cd28e951

📥 Commits

Reviewing files that changed from the base of the PR and between c119b88 and 67504d9.

📒 Files selected for processing (2)
  • apps/angular/8-pure-pipe/src/app/app.component.ts
  • apps/angular/8-pure-pipe/src/app/simple-pipe.pipe.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

AppComponent now uses SimplePipe to render each person with its index. The inline heavyComputation method was removed, and persons now has an explicit public string[] type.

Changes

Pure pipe rendering

Layer / File(s) Summary
SimplePipe integration
apps/angular/8-pure-pipe/src/app/simple-pipe.pipe.ts, apps/angular/8-pure-pipe/src/app/app.component.ts
SimplePipe formats a name and index as "name - index". AppComponent registers the pipe and uses it in the template instead of heavyComputation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 67504

This is a localized pure-pipe refactor with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: tomalaforge

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title starts with "Answer: 8" and clearly identifies the pipe refactor for challenge 8.
Description check ✅ Passed The description includes the required challenge checklist, sponsorship notice, and submission options from the repository template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request has been flagged as potential spam (promotional) by CodeRabbit slop detection and should be reviewed carefully.

@github-actions

Copy link
Copy Markdown

This pull request is stale because it has been open for 15 days with no activity.

@github-actions github-actions Bot added the stale label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8 exercice simple pipe answer answer stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant