Skip to content

Add French localization for bot messages#333

Open
Plexi09 wants to merge 4 commits into
tolik518:masterfrom
Plexi09:master
Open

Add French localization for bot messages#333
Plexi09 wants to merge 4 commits into
tolik518:masterfrom
Plexi09:master

Conversation

@Plexi09

@Plexi09 Plexi09 commented Mar 4, 2026

Copy link
Copy Markdown

This pull request adds a new French localization file

@Aras14HD

Aras14HD commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Looks good, tested it here and for that made a commit, that adds it to the library (code) and bumps the version.

Might take a bit until it is merged as tolik said, he's in the middle of moving. But should not be too long.

Thanks for contributing!

@tolik518

tolik518 commented Mar 4, 2026

Copy link
Copy Markdown
Owner

@Plexi09 if you know of any subreddits that are explicitly french, feel free to add them to the subreddits.json!
While we're trying to get the language automatically, this won't work for all subreddits sadly (in the last 30 days factorion only detected r/developpeurs as french)

@Plexi09

Plexi09 commented Mar 4, 2026

Copy link
Copy Markdown
Author

@Plexi09 if you know of any subreddits that are explicitly french, feel free to add them to the subreddits.json!

Yes I will do that

@tolik518

tolik518 commented Mar 6, 2026

Copy link
Copy Markdown
Owner

@Plexi09 do you want to add the subreddits in this PR, or do you need some time and want to add them later?

@Plexi09

Plexi09 commented Mar 6, 2026

Copy link
Copy Markdown
Author

@Plexi09 do you want to add the subreddits in this PR, or do you need some time and want to add them later?

I'll do some of them tomorrow

@tolik518

tolik518 commented Mar 6, 2026

Copy link
Copy Markdown
Owner

Perfect, thank you!

@tolik518

tolik518 commented May 7, 2026

Copy link
Copy Markdown
Owner

Hey @Plexi09 are you still interested in adding some french subreddits? Otherwise, I can also merge as it is

@Aras14HD

Copy link
Copy Markdown
Collaborator

@tolik518 I think as they haven't replied for over a month, we should just merge this. (Unless you have plans to work on this futher @Plexi09, otherwise you are also welcome to add subreddits in a separate PR as well)

I'll fix the merge conflicts right now

@tolik518

Copy link
Copy Markdown
Owner

@Aras14HD Yeah we definitely should do. I'll merge this tomorrow if we won't get a reply by then.

@Plexi09

Plexi09 commented Jun 11, 2026

Copy link
Copy Markdown
Author

Hi, sorry y'all, I it completely left my mind. I will add a list right now

@Plexi09

Plexi09 commented Jun 11, 2026

Copy link
Copy Markdown
Author

Done! You can merge

@Aras14HD

Copy link
Copy Markdown
Collaborator

No worries and thanks for the contribution!

@tolik518

tolik518 commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Thank you :)
I'll merge the changes later in the evening then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants