feat(online-interactive): add table queries and form#18
Merged
Conversation
AmritBhusal
requested review from
crsstha,
shreeyash07 and
subinasr
and removed request for
shreeyash07 and
subinasr
subinasr
requested changes
Jul 8, 2026
| const tableData: OnlineInteractiveListItem[] = useMemo(() => ( | ||
| (data?.reports?.results ?? []).map((report, index) => ({ | ||
| ...report, | ||
| no: String((page - 1) * limit + index + 1), |
Contributor
There was a problem hiding this comment.
Let's just make this 'number' type. I don't see any reason this should be a string.
AmritBhusal
force-pushed
the
feat/online-interactives
branch
from
c9a4edd to
312c27b
Compare
shreeyash07
requested changes
Jul 8, 2026
| import { TextInput } from '@ifrc-go/ui'; | ||
| import { type EntriesAsList } from '@togglecorp/toggle-form'; | ||
|
|
||
| import type { OnlineInteractiveFilterType } from '../index'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import type { OnlineInteractiveFilterType } from '../index'; | |
| import { type OnlineInteractiveFilterType } from '../index'; |
Comment on lines
+275
to
+279
| {isDefined(error?.file) && ( | ||
| <InputError> | ||
| {getErrorString(error.file)} | ||
| </InputError> | ||
| )} |
shreeyash07
force-pushed
the
feat/online-interactives
branch
from
c2dca46 to
da6ecad
Compare
shreeyash07
approved these changes
Jul 9, 2026
crsstha
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any
console.logmeant for debugging