feat(documents): add document table and queries by AmritBhusal · Pull Request #12 · toggle-corp/ercs-cms

AmritBhusal · 2026-07-01T10:12:35Z

Changes

add Documents tables and table actions
add table filters and search
add new route

This PR doesn't introduce any

shreeyash07 · 2026-07-03T08:25:04Z

+    contentType: ReportContentType.File,
+};
+
+const MAX_FILE_SIZE = 5 * 1024 * 1024; // 5MB


lets make this common constant

shreeyash07 · 2026-07-03T08:32:17Z

+
+    const handleFileChange = useCallback((file: File | undefined) => {
+        if (isDefined(file) && file.size > MAX_FILE_SIZE) {
+            alert.show('File must be 5MB or smaller', { variant: 'danger' });


we need to show this in non field error instead of alert, i think FileInput have size props to handle this.

subinasr

From now onwards, please try to adhere to the branch naming conventions.
For reference: https://notes.tools.togglecorp.com/6MN_ghZfS02ucm__t6_WCQ#

subinasr · 2026-07-09T08:21:07Z

+} from '@ifrc-go/ui';
+import { type EntriesAsList } from '@togglecorp/toggle-form';
+
+import type { DocumentFilterType } from '../index';


Suggested change

import type { DocumentFilterType } from '../index';

import type { DocumentFilterType } from '..';

subinasr · 2026-07-09T08:42:26Z

+function isAllowedReportType(value: string | null | undefined): value is ReportTypeEnum {
+    return isDefined(value) && (allowedReportTypes as string[]).includes(value);
+}
+


Way too many type casts. There might be a way to simpler write the same function.

subinasr · 2026-07-09T08:49:20Z

+    } = useForm(documentSchema, { value: initialValue });
+
+    const [{ data, fetching: documentDetailFetch }] = useDocumentDetailQuery({
+        variables: { id: isDefined(id) ? id : '' },


Why not send undefined when there's no id?

undefined causes a type error (id is generated as string), so ''

subinasr · 2026-07-09T08:52:11Z

+    const reportTypeOptions = useMemo(() => (
+        (enumsData?.enums?.ReportType ?? []).filter(
+            (option) => allowedReportTypes.includes(option.key),
+        )
+    ), [enumsData]);


I believe there's useGlobalEnums hook you can use instead of separately fetching the enums.

subinasr · 2026-07-09T09:03:34Z

+    useEffect(() => {
+        if (!documentDetailFetch && isDefined(documentData)) {
+            const {
+                ...otherValues
+            } = removeNull(documentData);
+
+            delete (otherValues as { file?: unknown }).file;
+            setValue({
+                ...otherValues,
+            });
+        }
+    }, [documentDetailFetch, documentData, setValue]);


Can you check this properly? This can be done without so much destructuring and mutation of the object.

subinasr · 2026-07-09T09:17:03Z

+                    title="File Upload"
+                    description="Upload the document file"
+                    withAsteriskOnTitle
+


Remove this line

subinasr · 2026-07-09T09:19:38Z

+function persistTab(value: string | null | undefined): ReportTypeEnum {
+    if (value === ReportTypeEnum.Policy || value === ReportTypeEnum.Guideline) {
+        return value;
+    }
+    return ReportTypeEnum.Manual;
+}
+


This function is unnecessary.

subinasr · 2026-07-09T09:35:19Z

+    const tableData: ReportsListItem[] = useMemo(() => (
+        (data?.reports?.results ?? []).map((report, index) => ({
+            ...report,
+            no: String((page - 1) * limit + index + 1),


You can keep this as a number unless you have a specific reason for the type cast.

subinasr · 2026-07-09T09:38:13Z


 import type { AdminAreaLevel } from '#generated/types/graphql';

+export const MAX_FILE_SIZE = 5 * 1024 * 1024; // 5MB


Let's use two common variables here. MAX_REPORT_FILE_SIZE and MAX_IMAGE_FILE_SIZE as the limits for the two are different.

subinasr · 2026-07-09T09:40:13Z

+                setSizeError(`File must be ${Math.round(maxSize / (1024 * 1024))}MB or smaller`);
+                onChange(undefined, inputName);


Is this necessary? What do you think @shreeyash07 ?

AmritBhusal marked this pull request as ready for review July 1, 2026 10:12

AmritBhusal requested review from crsstha, shreeyash07 and subinasr and removed request for crsstha, shreeyash07 and subinasr July 1, 2026 10:16

AmritBhusal assigned AmritBhusal and shreeyash07 and unassigned AmritBhusal Jul 1, 2026

AmritBhusal force-pushed the documents branch from cee3d12 to 14e10ec Compare July 2, 2026 09:29

AmritBhusal marked this pull request as draft July 9, 2026 05:18

crsstha approved these changes Jul 9, 2026

View reviewed changes

AmritBhusal force-pushed the documents branch from 14e10ec to b6429c4 Compare July 9, 2026 05:36

AmritBhusal marked this pull request as ready for review July 9, 2026 05:37

shreeyash07 reviewed Jul 9, 2026

View reviewed changes

AmritBhusal added 3 commits July 9, 2026 14:21

feat(documents): add document table and queries

80e9794

fixup! feat(documents): add document table and queries

be600ca

fixup! feat(documents): add document table and queries

2052eda

AmritBhusal force-pushed the documents branch from b6429c4 to 2052eda Compare July 9, 2026 09:13

subinasr requested changes Jul 9, 2026

View reviewed changes

fixup! feat(documents): add document table and queries

cf1d0f3

AmritBhusal requested a review from subinasr July 10, 2026 04:10

	import type { DocumentFilterType } from '../index';
	import type { DocumentFilterType } from '..';


		import type { AdminAreaLevel } from '#generated/types/graphql';

		export const MAX_FILE_SIZE = 5 * 1024 * 1024; // 5MB

		setSizeError(`File must be ${Math.round(maxSize / (1024 * 1024))}MB or smaller`);
		onChange(undefined, inputName);

Uh oh!

Conversation

AmritBhusal commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

This PR doesn't introduce any

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

subinasr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AmritBhusal commented Jul 1, 2026 •

edited

Loading