fix(executor): preserve SQL three-valued boolean logic [CODEX]#7961
Open
dev-willbird1936 wants to merge 1 commit into
Open
fix(executor): preserve SQL three-valued boolean logic [CODEX]#7961dev-willbird1936 wants to merge 1 commit into
dev-willbird1936 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7960.
The Python executor maps SQL boolean operators to Python truthiness, which makes
NOT NULLevaluate asTrueinstead of SQLUNKNOWN.This patch adds SQL-aware
NOT,AND,OR, andINhelpers. LazyANDandORoperands preserve decisive short-circuit behavior, and boolean normalization keeps compatible scalar values working.Regression tests cover nullable truth tables, nullable
WHEREfiltering,IN/NOT IN, NumPy boolean scalars, and evaluation count. The focused regressions, all 26 executor tests, Ruff, formatting, mypy, andgit diff --checkpass.Disclosure: I used OpenAI Codex to assist with analysis and implementation. I reviewed and validated every submitted change.