fix(optimizer): preserve negated correlations [CODEX] - #7959
Closed
dev-willbird1936 wants to merge 1 commit into
Closed
fix(optimizer): preserve negated correlations [CODEX]#7959dev-willbird1936 wants to merge 1 commit into
dev-willbird1936 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7958.
A direct
NOTaround a correlated comparison was lost during decorrelation because the inner comparison was replaced withTRUE. This change normalizes supported direct negated comparisons to their complementary operator, aggregates the inner key when no positive equality join key exists, and evaluates the preserved predicate withARRAY_ANYafter aLEFT JOIN ... ON TRUE.The regression covers
EXISTS,NOT EXISTS, the existing positive-equality path,NULL/UNKNOWN values, an all-NULL inner relation, and an empty inner relation.Validation:
unnest_subqueriesoptimizer fixture plus regressiongit diff --checkLLM disclosure: I used OpenAI Codex to assist with analysis, implementation, and test drafting. I reviewed the final diff and validated the behavior and tests.