fix(executor): preserve set operation multiplicity [CODEX]#7955
Open
dev-willbird1936 wants to merge 1 commit into
Open
fix(executor): preserve set operation multiplicity [CODEX]#7955dev-willbird1936 wants to merge 1 commit into
dev-willbird1936 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7954.
PythonExecutor.set_operationcurrently applies set semantics toINTERSECTandEXCEPTeven when the planned operation isALL. This change consumes right-side row counts forALL, while retaining one stable first occurrence forDISTINCT.The regression covers excess left multiplicity, unmatched rows, and both DISTINCT controls.
Validation:
python -m unittest tests.test_executor.TestExecutor.test_set_operationspython -m unittest tests.test_executor(21 tests)ruff check sqlglot/executor/python.py tests/test_executor.pyruff format --check sqlglot/executor/python.py tests/test_executor.pymypy sqlglot(180 source files)git diff --check origin/main...HEADLLM disclosure: Codex assisted with analysis, implementation review, and validation. I reviewed the final behavior, tests, and diff and take responsibility for the contribution.