feat: support "replace using" for insert DML#7950
Open
nlpersimon wants to merge 2 commits into
Open
Conversation
geooo109
reviewed
Jul 27, 2026
geooo109
left a comment
geooo109
left a comment
Collaborator
There was a problem hiding this comment.
We should always add support for:
REPLACE ON boolean_expression
| "REPLACE WHERE c1 > 0 REPLACE USING (c1, c2)", | ||
| "REPLACE USING (c1, c2) REPLACE WHERE c1 > 0", | ||
| ): | ||
| with self.subTest(replace=replace), self.assertRaises(ParseError): |
Collaborator
There was a problem hiding this comment.
No need for ParserError check, let's only focus on validate_identity and preserve the roundtrip.
Comment on lines
+3531
to
+3534
| if not replace_using: | ||
| self.raise_error("Expected at least one column in REPLACE USING", self._prev) | ||
| else: | ||
| self.raise_error("Expected WHERE or USING after REPLACE") |
Collaborator
There was a problem hiding this comment.
There is no need to raise here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #7949