feat(snowflake): transpile Snowflake IDENTIFIER function to DuckDB#7723
Open
fivetran-kwoodbeck wants to merge 3 commits into
Open
feat(snowflake): transpile Snowflake IDENTIFIER function to DuckDB#7723fivetran-kwoodbeck wants to merge 3 commits into
fivetran-kwoodbeck wants to merge 3 commits into
Conversation
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing:
Overallmain: 192441 total, 153536 passed (pass rate: 79.8%) sqlglot:transpile/snowflake-identifier-function: 110922 total, 110162 passed (pass rate: 99.3%) Transitions: Dialect pair changes: 0 previous results not found, 1 current results not found ✅ All tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake's
IDENTIFIER(), which resolves a string to a runtime identifier, previously fell through toexp.Anonymous. This folds it into a typedexp.Identifiernode (flagged withidentifier_func=True) so the Snowflake generator reconstructsIDENTIFIER('name')and the DuckDB generator emits a native identifier. It includes splitting dot-qualified names likeIDENTIFIER('t1.col')into a properexp.Dotchain.Non-foldable args like
IDENTIFIER($var)remain asexp.Anonymousso they round-trip correctly.Behavior