fix(transpile-bug): update core, generator, optimizer, and parser files for select-star-ilike-rename#7720
Open
fivetran-amrutabhimsenayachit wants to merge 1 commit into
Conversation
…es for select-star-ilike-rename
georgesittas
reviewed
Jun 8, 2026
Comment on lines
+892
to
+893
| for table in tables: | ||
| ilike_columns[id(table)] = pattern |
Collaborator
There was a problem hiding this comment.
Why do we repeat this pattern N times, one for every table? Just one suffices right?
Comment on lines
-3366
to
+3368
| return f"*{except_}{replace}{rename}" | ||
| ilike = self.sql(expression, "ilike") | ||
| ilike = f" ILIKE {ilike}" if ilike else "" | ||
| return f"*{ilike}{except_}{replace}{rename}" |
Collaborator
There was a problem hiding this comment.
What does generation look like when pretty=True? Since we made the effort of pretty-formatting the other clauses (RENAME, etc), let's do it for this one as well so that the output is consistent.
| this.set("unpack", True) | ||
| return this | ||
|
|
||
| ilike = self._parse_primary() if self._match(TokenType.ILIKE) else None |
Collaborator
There was a problem hiding this comment.
Why are we using _parse_primary() here? Should this be _parse_string()? What if the user supplies a placeholder / parameter, is that handled?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: