Feat(starrocks)!: improve some starrocks properties generation #6827

jaogoy · 2026-01-21T08:52:18Z

Depends on #6804.
Please review/merge #6804 first.
This PR contains changes on top of that PR. And you can review the diff only.

Import expression partitioning for MV.
Enabled ALTER TABLE … RENAME for StarRocks. (Moved alterrename_sql from Doris into MySQL, because it's the same for them all.)
Emitted ORDER BY via CLUSTER BY for StarRocks outputs.
Added MV (REFRESH) properties handling for StarRocks materialized
views.
And, tests updated/added for the new StarRocks behaviors.

jaogoy · 2026-01-21T09:05:13Z

I create this PR to replace #6737, which is closed by mistake.
And it depends on #6804, which also supports partitioning parse and generation, submitted by @petrikoro.

Please have a review. Thanks.

cc @georgesittas @VaggelisD

VaggelisD · 2026-01-22T09:51:21Z

sqlglot/dialects/starrocks.py

            exp.RollupProperty: exp.Properties.Location.POST_SCHEMA,
            exp.PartitionByListProperty: exp.Properties.Location.POST_SCHEMA,
            exp.PartitionedByProperty: exp.Properties.Location.POST_SCHEMA,
+            exp.RefreshTriggerProperty: exp.Properties.Location.POST_SCHEMA,


Looks like this is the case for Doris as well, does MySQL have this property? Otherwise, we can move both Doris & Starrocks's to MySQL and have it inherited

For MySQL, it doesn't support MV.

There are different between Doris and StarRocks for the REFRESH clause, both for the syntax and keywords.

Right, I meant that this line is also true in Doris so we can move the POST_SCHEMA to either MySQL's generator or the base generator instead of duplicating it in both Doris & Starrocks

Yes, I'll move it to the base generator. (It's not proper for MySQL.)

sqlglot/dialects/starrocks.py

tests/dialects/test_starrocks.py

sqlglot/dialects/starrocks.py

sqlglot/dialects/mysql.py

VaggelisD · 2026-01-23T14:22:06Z

sqlglot/dialects/starrocks.py

            exp.RollupProperty: exp.Properties.Location.POST_SCHEMA,
            exp.PartitionByListProperty: exp.Properties.Location.POST_SCHEMA,
            exp.PartitionedByProperty: exp.Properties.Location.POST_SCHEMA,
+            exp.RefreshTriggerProperty: exp.Properties.Location.POST_SCHEMA,


Right, I meant that this line is also true in Doris so we can move the POST_SCHEMA to either MySQL's generator or the base generator instead of duplicating it in both Doris & Starrocks

geooo109 · 2026-01-26T14:45:40Z

@jaogoy can you rebase on top of main ? I merged #6804 + refactored it.

Depends on tobymao#6804 Please review/merge tobymao#6804 first. This PR only contains changes on top of that PR. - Import expression partitioning for MV. - Enabled ALTER TABLE … RENAME for StarRocks. - Emitted ORDER BY via CLUSTER BY for StarRocks outputs. - Added MV (REFRESH) properties handling for StarRocks materialized views. - And, tests updated/added for the new StarRocks behaviors. Signed-off-by: jaogoy <jaogoy@gmail.com>

1. move alterrename_sql to mysql 2. implement parse_refresh_property for starrocks 3. refine refresh property generatation Signed-off-by: jaogoy <jaogoy@gmail.com>

Signed-off-by: jaogoy <jaogoy@gmail.com>

jaogoy · 2026-01-28T03:49:59Z

@jaogoy can you rebase on top of main ? I merged #6804 + refactored it.

@geooo109 @VaggelisD I've rebased the code, and solve the conflict. You can have a look again. thanks.

Signed-off-by: jaogoy <jaogoy@gmail.com>

geooo109 · 2026-01-28T09:08:59Z

@jaogoy I will check it, thank you.

For the PARTITION BY with parentheses see: #6804 (comment)

We can parse them but we generate without PARTITION BY Starrocks

edit: i will refactor it to generate parentheses by default, in order to support the superset.

geooo109 · 2026-01-28T15:43:20Z

@jaogoy can you fix the styling ?

edit: I will merge, fix style and refactor, thanks for the PR!

jaogoy · 2026-01-29T02:02:55Z

@jaogoy I will check it, thank you.

For the PARTITION BY with parentheses see: #6804 (comment)

We can parse them but we generate without PARTITION BY Starrocks

@geooo109 The StarRocks docs can't reflect all the real behavior. I've tested the creation on v3.5, only DUPLICATE KEY tables can be created without parentheses when using column only partitioning. And I don't know whether they will fix it.
So, when used by SQLMesh, it can't create primary key tables with column only partitioning without parentheses.

geooo109 · 2026-01-29T11:30:43Z

@jaogoy If we always generate by default parentheses, it will be correct right ?

jaogoy · 2026-01-30T07:08:56Z

@jaogoy If we always generate by default parentheses, it will be correct right ?

Yes, for columns only partitioning, it will be correct for all cases.

jaogoy mentioned this pull request Jan 21, 2026

Feat(starrocks)!: improve some StarRocks sql generation #6737

Closed

jaogoy mentioned this pull request Jan 22, 2026

Feat: Add StarRocks engine support TobikoData/sqlmesh#5658

Open

VaggelisD reviewed Jan 22, 2026

View reviewed changes

VaggelisD reviewed Jan 23, 2026

View reviewed changes

jaogoy added 5 commits January 28, 2026 10:16

feat(starrocks)!: optimize the code according to review comments

de712a5

1. move alterrename_sql to mysql 2. implement parse_refresh_property for starrocks 3. refine refresh property generatation Signed-off-by: jaogoy <jaogoy@gmail.com>

optimize code style

bbd820b

Signed-off-by: jaogoy <jaogoy@gmail.com>

move RefreshProperty location into base generator

b3f0e0e

Signed-off-by: jaogoy <jaogoy@gmail.com>

rebase code

b0df46e

Signed-off-by: jaogoy <jaogoy@gmail.com>

jaogoy force-pushed the improv.sr-based-on-pr-6804 branch from 41194d5 to b0df46e Compare January 28, 2026 03:43

modify the parentheses for partition

af1c2de

Signed-off-by: jaogoy <jaogoy@gmail.com>

geooo109 approved these changes Jan 28, 2026

View reviewed changes

geooo109 merged commit c6bfe61 into tobymao:main Jan 28, 2026
3 of 9 checks passed

geooo109 mentioned this pull request Jan 29, 2026

chore: refactor starrocks #6880

Merged

Feat(starrocks)!: improve some starrocks properties generation #6827

Feat(starrocks)!: improve some starrocks properties generation #6827

Conversation

jaogoy commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaogoy commented Jan 21, 2026

Uh oh!

VaggelisD Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

jaogoy Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

VaggelisD Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

jaogoy Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VaggelisD Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

geooo109 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaogoy commented Jan 28, 2026

Uh oh!

geooo109 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geooo109 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jaogoy commented Jan 29, 2026

Uh oh!

geooo109 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaogoy commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jaogoy commented Jan 21, 2026 •

edited

Loading

geooo109 commented Jan 26, 2026 •

edited

Loading

geooo109 commented Jan 28, 2026 •

edited

Loading

geooo109 commented Jan 28, 2026 •

edited

Loading

geooo109 commented Jan 29, 2026 •

edited

Loading