Drop support for tmux versions < 3.2 #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflects the minimum version bump in v1.57.0 via libtmux 0.48.0.
- Update minimum version requirement from 1.8 to 3.2 - Remove outdated version reference for unique IDs feature (available since 1.8)
- Update from "written for version 1.8" to "requires tmux 3.2 or newer" - Update tmux homepage link to GitHub (sourceforge is outdated)
Update the plugin system's minimum tmux version constant from 1.8 to 3.2.
Also fix comment typo ("libtmux" -> "tmuxp").
Remove dead code that warned users about environment variable support requiring tmux 3.0+. Since tmux 3.2+ is now the minimum version, environment variables are always supported. - Remove warning blocks for windows and panes - Remove unused has_lt_version import
The terminal size detection feature was gated behind a tmux 2.6+ check. Since tmux 3.2+ is now the minimum version, this check is always true. - Simplify condition to only check TMUXP_DETECT_TERMINAL_SIZE env var - Remove unused has_gte_version import
Remove historical documentation about tmux 2.6 layout behavior changes. This is no longer relevant as a "versionchanged" note since tmux 3.2+ is now the minimum version.
Remove skip marker for test_load_workspace_name_match_regression_252. This test was skipped for tmux < 2.1, which is no longer relevant now that tmux 3.2+ is the minimum version.
- Remove skip marker from test_environment_variables (was for tmux < 3.0) - Delete test_environment_variables_warns_prior_to_tmux_3_0 entirely (tested warning behavior that no longer exists)
Remove conditional pane-border-format setup and assertion. The feature is always available since tmux 3.2+ is now the minimum version.
tony
force-pushed
the
drop-old-tmux-versions-pt2
branch
from
12a3054 to
6c727f0
Compare
Remove skip marker from test_start_directory_sets_session_path. This test uses a format introduced in tmux 3.2a, which is now the minimum version.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
==========================================
+ Coverage 72.38% 72.92% +0.53%
==========================================
Files 26 26
Lines 1854 1839 -15
Branches 352 347 -5
==========================================
- Hits 1342 1341 -1
+ Misses 407 395 -12
+ Partials 105 103 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove skip markers from test_layout_main_horizontal and test_issue_800_default_size_many_windows - Remove unused has_lt_version import These features are always available since tmux 3.2+ is now the minimum version.
Update installation requirements to reflect the new minimum tmux version.
Environment variable support is always available now that tmux 3.2+ is the minimum version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old tmux version references (< 3.2)
Summary
Clean up all references to tmux versions older than 3.2 now that the minimum
version has been bumped to tmux 3.2+ (via libtmux 0.48.0 in tmuxp v1.57.0).
This PR removes:
Changes
Code cleanup (~35 lines removed)
has_lt_version("3.0")blocks for environmentvariable warnings (feature always available now)
has_gte_version("2.6")check for terminal sizedetection (always true now)
TMUX_MIN_VERSIONconstant from "1.8" to "3.2"Test cleanup (~70 lines removed)
test_environment_variables_warns_prior_to_tmux_3_0testpane-border-formatsetup (tmux 2.3 feature)has_lt_version/has_gte_versionimportsDocumentation updates
See also