-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for partial results tracking on a scan #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MFormenti
wants to merge
8
commits into
main
Choose a base branch
from
webapp_partial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add RUNNING status to JobStatus enum - Add ThreadLocal in BulkScanWorker to pass ScanJobDescription to scan implementations - Add upsertPartialScanResult() method to IPersistenceProvider interface - Implement upsertPartialScanResult() in MongoPersistenceProvider - Update DummyPersistenceProvider test implementation - Update BulkScanWorkerManager to pass ScanJobDescription to worker.handle() This enables real-time persistence of intermediate scan results to MongoDB as probes complete during TLS scans.
… input. scanTarget can be accessed from scanJobDescription, and the UUID in scanJobDescription is needed to write partial results to MongoDB during a scan
Contributor
|
Add one more test using DummyPersistenceProvider to check the partial results. |
…ersistenceProvider
juaninf
reviewed
Nov 26, 2025
src/main/java/de/rub/nds/crawler/core/BulkScanWorkerManager.java
Outdated
Show resolved
Hide resolved
juaninf
reviewed
Nov 26, 2025
juaninf
reviewed
Nov 26, 2025
juaninf
reviewed
Nov 26, 2025
Contributor
juaninf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments
Replace all hostname usages with TEST-NET-1 IPs (RFC 5737)
Contributor
|
looks good to me @XoMEX are you ok with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds infrastructure to support partial results by providing scan implementations access to their ScanJobDescription context during execution
Added: