Repository navigation
Conversation
The Summary of TLA+ gives SUBSET, UNION, \cup, and \ precedence 8-8. Equal precedence leaves the binding unspecified, and TLA+ rejects the expression. SANY has given SUBSET and UNION precedence 10-13, under which SUBSET S \ T parses as (SUBSET S) \ T and A \cup UNION B as A \cup (UNION B). tlaplus#1508 restores the documented ranges, so the unparenthesized forms become syntax errors. The parentheses keep the binding SANY has been using. Related to Github RFC issue #28 tlaplus/rfcs#28 See Github pull request #1508 tlaplus/tlaplus#1508 Co-authored-by: Grok 4.7 <noreply@x.ai> Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the set-operator grouping changes.
No open issues 🎉
What changed in this PR
This PR makes set-operator grouping explicit in three TLA+ specifications, preserving SANY’s existing interpretation while preparing for the documented precedence rules.
Changes:
- Parenthesizes
UNIONexpressions used with set union. - Parenthesizes
SUBSET Keybefore set subtraction in both PlusCal and its TLA+ translation. - Updates the PlusCal translation checksums.
| File | Description |
|---|---|
specifications/LevelChecking/LevelSpec.tla |
Clarifies UNION grouping in level-constraint calculations. |
specifications/KeyValueStore/KVsnap.tla |
Clarifies nonempty key-set selection and updates translation checksums. |
specifications/allocator/AllocatorImplementation.tla |
Clarifies UNION grouping in allocation invariants. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Summary of TLA+ gives SUBSET, UNION, \cup, and \ precedence 8-8. Equal precedence leaves the binding unspecified, and TLA+ rejects the expression. SANY has given SUBSET and UNION precedence 10-13, under which SUBSET S \ T parses as (SUBSET S) \ T and A \cup UNION B as A \cup (UNION B). tlaplus#1508 restores the documented ranges, so the unparenthesized forms become syntax errors. The parentheses keep the binding SANY has been using.
Related to Github RFC issue #28
tlaplus/rfcs#28
See Github pull request #1508
tlaplus/tlaplus#1508