Skip to content

Try to sort search paths by psql version #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romuald wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try to sort search paths by psql version #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/testing/postgresql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,36 @@
import subprocess
from glob import glob
from contextlib import closing
from distutils.version import LooseVersion

from testing.common.database import (
Database, DatabaseFactory, get_path_of, SkipIfNotInstalledDecorator
)


__all__ = ['Postgresql', 'skipIfNotFound']


def sorted_paths(glob_pattern):
"""
Try to return search paths sorted by version number
(latest version first)

"""
values = glob(glob_pattern)
try:
idx = glob_pattern.index('*')

# -> [('9.4', '/usr/lib/postgresql/9.4')]
matches = [(LooseVersion(match[idx:]), match) for match in values]

return [path for _, path in sorted(matches, reverse=True)]
except Exception:
return values

SEARCH_PATHS = (['/usr/local/pgsql', '/usr/local'] +
glob('/usr/pgsql-*') + # for CentOS/RHEL
glob('/usr/lib/postgresql/*') + # for Debian/Ubuntu
glob('/opt/local/lib/postgresql*')) # for MacPorts
sorted_paths('/usr/pgsql-*') + # for CentOS/RHEL
sorted_paths('/usr/lib/postgresql/*') + # for Debian/Ubuntu
sorted_paths('/opt/local/lib/postgresql*')) # for MacPorts


class Postgresql(Database):
Expand Down