Skip to content

Keep live module page fixture open for repeated requests - #24

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:tinybrowser-live-fixture
Sep 25, 2026
Merged

senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:tinybrowser-live-fixture

Conversation

@senamakel

Copy link
Copy Markdown
Member

Summary

Keep the TinyBus module adapter's loopback page fixture listening for multiple browser connections. The helper previously accepted one TCP connection, sent one response, then dropped its listener. Chrome can open another connection during the same navigation, causing net::ERR_CONNECTION_REFUSED. This failed the live module test during PR #22's 90% Chrome coverage job in CI run 36088099803.

Related issue

Unblocks the required Rust/coverage check for #22; CI run 36088099803.

API or behavior changes

None. This changes only a test fixture server.

Validation

  • New regression failed before the fix on its second request with ConnectionRefused, then passed after the fix
  • Live Chrome TinyBus member test passed four times after the fix (one initial run plus three repeats)
  • cargo fmt --all -- --check
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo build --locked --all-targets --all-features
  • cargo test --locked --all-features --quiet
  • git diff --check

Tests

Added a browser-free regression that sends two complete HTTP requests to the page fixture and asserts both receive the test document. The opted-in live Chrome test remains enabled and unchanged.

Documentation

No user-facing contract changed. Updated the fixture comment to describe its repeated-request behavior.

Checklist

  • The change is focused on one logical change
  • No new allow attributes, ignored tests, or relaxed lints
  • No secrets, tokens, or environment files in the diff or description

@tinysweeper

tinysweeper Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 3a4318457074
Updated: 1790305558 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 1 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["options<br/>changed"]:::changed
  n1["live_every_member_answers_over_a_real_bus"]:::impacted
  n2["..._download_handle_round_trips_over_the_bus"]:::impacted
  n3["connected"]:::impacted
  n4["...lure_keeps_its_error_name_across_the_wire"]:::impacted
  n5["methods"]:::impacted
  n6["assert_download_members"]:::impacted
  n1 -->|calls| n0
  n1 -->|tests| n0
  n1 -->|calls| n3
  n1 -->|tests| n3
  n1 -->|uses| n5
  n1 -->|calls| n6
  n1 -->|tests| n6
  n2 -->|calls| n0
  n2 -->|tests| n0
  n2 -->|calls| n3
  n2 -->|tests| n3
  n2 -->|uses| n5
  n4 -->|calls| n0
  n4 -->|tests| n0
  n4 -->|calls| n3
  n4 -->|tests| n3
  n4 -->|uses| n5
  n6 -->|uses| n5
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The fixture now accepts concurrent and repeated browser connections, and the added regression test verifies that behavior. The change looks safe to merge; the long-lived listener tasks are test-process scoped and do not affect production code. _2 memory call(s) failed (model: cortex: v1/answer: timed out after 20s), so this review saw part of what the engine holds._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The fixture now handles repeated browser requests and adds a deterministic regression test for that behavior. The change is limited to test infrastructure and looks safe to merge. _2 memory call(s) failed (model: cortex: v1/answer: timed out after 20s), so this review saw part of what the engine holds._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change correctly wraps the test fixture's accept loop so it handles multiple connections, fixing a connection-refused failure when Chrome opens a second TCP connection. The new regression test verifies repeated requests and follows the repository's testing conventions. No issues introduced. Safe to merge. (Note: I checked the diff and the PR description. The diff shows a clean change. The repository's rules about gating live tests do not apply because this is a loopback fixture, consistent with existing tests. No findings.) _2 memory call(s) failed (model: cortex: v1/answer: timed out after 20s), so this review saw part of what the engine holds._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash
  • Spend: $0.003332
  • Tokens: 76385 input · 6956 output · 6634 cached · 170 embedding
Head State Pass summary
3a4318457074 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790305558)

tinysweeper 0.1.0

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 49 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 428b5dd4-16e4-4bc6-b827-561074af77b0

📥 Commits

Reviewing files that changed from the base of the PR and between 0e719ef and 3a43184.

📒 Files selected for processing (1)
  • crates/tinybrowser/src/tinybus_module/test.rs

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0033 · 76,385 in / 6,956 out · 6,634 cached (9%)  · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 170 embedded
critique:    $0.0009 · 33,592 in / 1,132 out · 2,031 cached (6%)  · gpt-5.6-luna
security:    $0.0009 · 33,104 in / 942 out   · 1,787 cached (5%)  · gpt-5.6-luna
description: $0.0010 · 7,366 in  / 2,550 out · 2,304 cached (31%) · deepseek/deepseek-v4-flash

@senamakel
senamakel merged commit ac6c51e into tinyhumansai:main Sep 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant