Keep live module page fixture open for repeated requests - #24
Conversation
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["options<br/>changed"]:::changed
n1["live_every_member_answers_over_a_real_bus"]:::impacted
n2["..._download_handle_round_trips_over_the_bus"]:::impacted
n3["connected"]:::impacted
n4["...lure_keeps_its_error_name_across_the_wire"]:::impacted
n5["methods"]:::impacted
n6["assert_download_members"]:::impacted
n1 -->|calls| n0
n1 -->|tests| n0
n1 -->|calls| n3
n1 -->|tests| n3
n1 -->|uses| n5
n1 -->|calls| n6
n1 -->|tests| n6
n2 -->|calls| n0
n2 -->|tests| n0
n2 -->|calls| n3
n2 -->|tests| n3
n2 -->|uses| n5
n4 -->|calls| n0
n4 -->|tests| n0
n4 -->|calls| n3
n4 -->|tests| n3
n4 -->|uses| n5
n6 -->|uses| n5
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 49 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0033 · 76,385 in / 6,956 out · 6,634 cached (9%) · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 170 embedded
critique: $0.0009 · 33,592 in / 1,132 out · 2,031 cached (6%) · gpt-5.6-luna
security: $0.0009 · 33,104 in / 942 out · 1,787 cached (5%) · gpt-5.6-luna
description: $0.0010 · 7,366 in / 2,550 out · 2,304 cached (31%) · deepseek/deepseek-v4-flash
Summary
Keep the TinyBus module adapter's loopback page fixture listening for multiple browser connections. The helper previously accepted one TCP connection, sent one response, then dropped its listener. Chrome can open another connection during the same navigation, causing net::ERR_CONNECTION_REFUSED. This failed the live module test during PR #22's 90% Chrome coverage job in CI run 36088099803.
Related issue
Unblocks the required Rust/coverage check for #22; CI run 36088099803.
API or behavior changes
None. This changes only a test fixture server.
Validation
Tests
Added a browser-free regression that sends two complete HTTP requests to the page fixture and asserts both receive the test document. The opted-in live Chrome test remains enabled and unchanged.
Documentation
No user-facing contract changed. Updated the fixture comment to describe its repeated-request behavior.
Checklist