runtime: add MemStats.NumGC for API compatibility - #5590
Open
0pcom wants to merge 1 commit into
Open
Conversation
TinyGo's GC does not count cycles, so this stays 0 and says so. It exists because reading runtime.MemStats.NumGC is common enough in dependency code that its absence is a compile error for programs that never look at the value.
Member
|
Normally when we add fields to runtime.MemStats, we try to implement them for the garbage collectors where possible. Could you add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.MemStatsis missingNumGC, so any program that reads it fails to compile — including programs that only log it.TinyGo's GC does not count cycles, so the field stays 0 and the doc comment says exactly that rather than implying a number nobody maintains. The same approach the struct already takes for other fields it cannot fill.
Verified by building TinyGo.