wasm: patch wasm_exec.js and wasm_exec_node.js from Go 1.18+#5483
Open
Darckfast wants to merge 1 commit into
Open
wasm: patch wasm_exec.js and wasm_exec_node.js from Go 1.18+#5483Darckfast wants to merge 1 commit into
Darckfast wants to merge 1 commit into
Conversation
Port this commit golang/go@680caf1 removing polyfills from `wasm_exec.js`, now the environment is expected to provide all the required polyfills. `wasm_exec.js` now only provides stub fallbacks for globalThis.fs and globalThis.process. All NodeJS specific code is now in a separate file `wasm_exec_node.js` with its required polyfills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port these commits:
golang/go@680caf1 Removes polyfills from
wasm_exec.jsgolang/go@04d8d24 Enables ECMAScript strict mode on
wasm_exec.jsgolang/go@ff34676 Replace deprecated
substrwithsubstringthis fixes #5370
NOTE: i added some polyfill on
wasmexit.js,wasmfunc.jsandwasmfunc.jstests files to keep compatibility with node 18