Skip to content

all: use unsafe.Add() where possible#5396

Draft
dgryski wants to merge 1 commit into
tinygo-org:devfrom
dgryski:dgryski/unsafe-add
Draft

all: use unsafe.Add() where possible#5396
dgryski wants to merge 1 commit into
tinygo-org:devfrom
dgryski:dgryski/unsafe-add

Conversation

@dgryski
Copy link
Copy Markdown
Member

@dgryski dgryski commented May 11, 2026

No description provided.

@dgryski dgryski force-pushed the dgryski/unsafe-add branch from f092bd9 to ad16d26 Compare May 11, 2026 23:22
@dgryski dgryski marked this pull request as draft May 11, 2026 23:44
@dgryski
Copy link
Copy Markdown
Member Author

dgryski commented May 11, 2026

Oof.. my semgrep rule tried to fix places with address constants, which don't play nicely with unsafe.Add(). We still need the unsafe.Pointer(uintptr(...)). Need to be more caseful.

@dgryski
Copy link
Copy Markdown
Member Author

dgryski commented May 12, 2026

Ooh, now interp failures. This is not a simple search and replace..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant