Batch 5: MLB API abstraction layer and single-pass box score render#31
Open
tinkerwise wants to merge 1 commit into
Open
Batch 5: MLB API abstraction layer and single-pass box score render#31tinkerwise wants to merge 1 commit into
tinkerwise wants to merge 1 commit into
Conversation
- Add src/scripts/mlbApi.js centralizing all MLB Stats API fetch() calls - Refactor scores.js and sidebars.js to import from mlbApi.js instead of constructing URLs inline; all endpoint logic now lives in one place - Fix box score popover flash: show loading skeleton, await all pending fetches with Promise.allSettled, then render the complete popover once https://claude.ai/code/session_01C1vhzbYUCRYNikqatrcAYN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
Summary
src/scripts/mlbApi.jscentralizes all MLB Stats API URL construction and fetching in named async functionsscores.jsandsidebars.jsrefactored to import frommlbApi.js— no more inline URL stringsPromise.allSettled, then renders exactly once — eliminating the visible re-render flashFiles changed
src/scripts/mlbApi.js— new file, 10+ named API functionssrc/scripts/scores.js— imports frommlbApi.js,showBoxScore()made async with single-pass rendersrc/scripts/sidebars.js— imports frommlbApi.js, direct fetch calls removedTest plan
Generated by Claude Code