Skip to content

Batch 4: Housekeeping — audio path, overnight refresh, CC theme, reader modal#30

Open
tinkerwise wants to merge 1 commit into
mainfrom
feature/batch-4-housekeeping
Open

Batch 4: Housekeeping — audio path, overnight refresh, CC theme, reader modal#30
tinkerwise wants to merge 1 commit into
mainfrom
feature/batch-4-housekeeping

Conversation

@tinkerwise

Copy link
Copy Markdown
Owner

Closes #25

Summary

Four small targeted fixes from the site review:

  • Audio path in easter-eggs.js uses a BASE constant instead of a hardcoded absolute path
  • Auto-refresh skips API calls between midnight and 9am
  • City Connect Friday auto-theme only applies when the user has no stored preference
  • Reader modal styles use CSS variables so they respect dark/light/CC themes

Files changed

  • src/scripts/easter-eggs.jsBASE constant for audio path
  • src/scripts/app.jsgetHours() < 9 guard on refresh interval
  • src/scripts/theme.js — CC Friday only when !prefs.theme
  • public/style.css — reader modal uses var(--surface), var(--text), var(--border)

Test plan

  • Orioles Magic audio plays (if you can trigger the easter egg)
  • Verify no API calls fire between midnight–9am (check Network tab on a timer tick)
  • Set theme to Dark, wait for Friday (or mock date) — Dark theme should hold, not switch to CC
  • Open reader modal in dark mode — panel should be dark, not a white flash

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Housekeeping: audio path, overnight refresh, CC theme, reader modal theming

2 participants