Skip to content

dhcp: if first ntp invocation fails, set time manually and retry#304

Merged
mergify[bot] merged 1 commit intotinkerbell:mainfrom
rpardini:pr/dhcp-if-first-ntp-invocation-fails-set-time-manually-and-retry
Feb 3, 2026
Merged

dhcp: if first ntp invocation fails, set time manually and retry#304
mergify[bot] merged 1 commit intotinkerbell:mainfrom
rpardini:pr/dhcp-if-first-ntp-invocation-fails-set-time-manually-and-retry

Conversation

@rpardini
Copy link
Member

@rpardini rpardini commented Dec 19, 2025

  • 🍃 some machines have no RTC at all, or an RTC with a failed battery
  • 🌴 in certain situations, ntpd fails with "Alarm Clock" when trying to do too-big a jump
  • 🌵 in this case, set system time to the date of the dhcpd binary and retry
  • 🌳 yet-another-case where systemd would have saved us from pain

- some machines have no RTC at all, or an RTC with a failed battery
- in certain situations, ntpd fails with "Alarm Clock" when trying to do too-big a jump
- in this case, set system time to the date of the dhcpd binary and retry
- yet-another-case where systemd would have saved us from pain

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
@rpardini rpardini force-pushed the pr/dhcp-if-first-ntp-invocation-fails-set-time-manually-and-retry branch from 4b05820 to ffb856b Compare January 20, 2026 18:11
@rpardini rpardini marked this pull request as ready for review January 20, 2026 18:12
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Feb 3, 2026
@mergify mergify bot added the queued label Feb 3, 2026
mergify bot added a commit that referenced this pull request Feb 3, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2026

Merge Queue Status

✅ The pull request has been merged at ffb856b

This pull request spent 6 minutes 27 seconds in the queue, including 6 minutes 8 seconds running CI.
The checks were run on draft #317.

Required conditions to merge

@mergify mergify bot merged commit 0252f62 into tinkerbell:main Feb 3, 2026
31 checks passed
@mergify mergify bot removed the queued label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments