tests: add regression coverage for run_vulkan launcher selection#48
Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
Draft
tests: add regression coverage for run_vulkan launcher selection#48cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor[bot] wants to merge 1 commit intonext-gen-5from
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add deterministic regression coverage for the Vulkan launcher script path/arch selection logic.
Risky behavior now covered
scripts/run_vulkan.shlaunched fromscripts/should prefer siblingrelease/idtech3(not a same-dir fallback copy).arm64/aarch64, launcher should executerelease/idtech3.aarch64when present.arm64/aarch64, launcher should reliably fall back torelease/idtech3whenidtech3.aarch64is absent.Test files added/updated
tests/scripts/test_run_vulkan.shCMakeLists.txt(registertest_run_vulkan_launcherin CTest with labelsunit;regression;scripts)Why this materially reduces regression risk
run_vulkan.shis a shared entrypoint used by ARM and desktop Vulkan launch workflows. Recent production changes modified binary discovery semantics; regressions here can silently launch the wrong binary or fail on ARM devices. These tests exercise the highest-risk branching logic in an isolated temp layout with stubbed binaries/uname, making them deterministic and fast while directly validating real launch decisions.Validation
tests/scripts/test_run_vulkan.sh scripts/run_vulkan.shctest -R test_run_vulkan_launcher --output-on-failure(frombuild-vk-Releaseafter reconfigure)