Big upgrade and merge of PR #570
Conversation
…original email ones. Modified calls for emails to add the Slack calls.
…. Added unit test. Moved settings to proper place.
Merging Slack integration.
…tore proper footer. Restore deleted template.
…e. Clean up CSS files. Restore markup on email template.
…and remove console.log on login.js lib file.
…ld to the database schema using the correct tool. This avoids any possible issues for integration with current master and anyone installing the app from scracth.
…mports. Correct sending msg to supervisor twice instead of supervisor and requester on new leave request. Fixed issue on same method on finishing promise.
…ttings not saved when using MySQL (datatype issue).
|
merging in aliengen fork |
Would you say this is still the case? |
|
@alexleach We are currently using it on "production" with the corresponding Docker image we built. It is working for us with our current usage. I would say the main issue we have is that the variables in the email template are not set properly. Unfortunately, I do not have availability to fix more issues. I'm staying available if anyone want to contribute and make some progress with it. |
|
Thanks for the quick reply! Your docker image looks great, lots of options available! It is almost two years old though, so I imagine lots of packages need bumping? I spent some time yesterday working on building a docker image from the main repo. I kept having issues with node-gyp trying to build an outdated sqlite3 extension, and then I think issues with the preinstall script. Plus there are 12 Critical Security issues that require breaking package updates... This main repo has been sadly neglected, unfortunately. Thanks for all your team's efforts on trying to keep this project alive. I'll try again to get it deployed internally later today. I've got it to a state where my Dockerfile and compose.yaml files can start the node app, redis and mariadb images now, so I think I'm nearly there... If I can contribute anything obvious, I'll submit a PR, but I wasn't intending on putting this much time into it tbh! |
…les not passing. Update of dependencies. Switch to node 20.
|
I've updated node to the version 20 and fixed a few issues including the issue with the mail template variables. There is still a need to upgrade all of the dependencies, but this is another amount of work... |
This fixes a TypeError occurring when adding a department:
TypeError: Expected a string but received a Boolean
The issue was in `departments.js` where `validator.toBoolean()` was called on a boolean expression. The `validator` library expects a string input, so passing a boolean caused the error.
Changes
- Replaced:
```js
const include_public_holidays = validator.toBoolean(
getParam('include_public_holidays') === 'on'
)
const is_accrued_allowance = validator.toBoolean(
getParam('is_accrued_allowance') === 'on'
)
Fix boolean conversion error in departments.js
8 participants
Hello,
Thanks for the work done on TimeOff.Management!
Here is the summary of changes:
Theses are breaking changes for current version running on production, I would more consider this as a starting point for a v2.
The code is not stable yet, and I'm still working at fixing remaining issues.