-
Notifications
You must be signed in to change notification settings - Fork 753
config: add option to skip rawkv region bound #10115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… (tikv#358) * [release 8.1] cp disable-raw-kv-region-split (tikv#292) * Add option to skip split rawkv regions (tikv#217) * add option to skip rawkv region bound Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> --------- Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * make check Signed-off-by: zeminzhou <zhouzemin@pingcap.com> --------- Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10115 +/- ##
==========================================
+ Coverage 78.40% 78.46% +0.06%
==========================================
Files 518 518
Lines 69438 69412 -26
==========================================
+ Hits 54441 54465 +24
+ Misses 11045 11012 -33
+ Partials 3952 3935 -17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| // WaitRegionSplitTimeout indicates the max duration to wait region split. | ||
| WaitRegionSplitTimeout typeutil.Duration `toml:"wait-region-split-timeout" json:"wait-region-split-timeout"` | ||
| // DisableRawKVRegionSplit indicates whether to skip raw kv region split. | ||
| DisableRawKVRegionSplit bool `toml:"disable-raw-kv-region-split" json:"disable-raw-kv-region-split,string"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add some comment about this configuration only work in keyspace,
| defaultGCTunerThreshold = 0.6 | ||
| minGCTunerThreshold = 0 | ||
| maxGCTunerThreshold = 0.9 | ||
| defaultDisableRawKVRegionSplit = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be true, most case user don't use raw kv in keyspace clustger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user cluster only uses the raw api, how to avoid splitting the txn key?
| // makeKeyRanges encodes keyspace ID to correct LabelRule data. | ||
| func makeKeyRanges(id uint32, skipRaw bool) any { | ||
| regionBound := MakeRegionBound(id) | ||
| if skipRaw { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But waitKeyspaceRegionSplit will call CheckKeyspaceRegionBound, and it always checks raw bound and txn bound
func (manager *Manager) CheckKeyspaceRegionBound(id uint32) bool {
regionBound := MakeRegionBound(id)
return manager.checkBound(regionBound.RawLeftBound) &&
manager.checkBound(regionBound.RawRightBound) &&
manager.checkBound(regionBound.TxnLeftBound) &&
manager.checkBound(regionBound.TxnRightBound)
}
What problem does this PR solve?
Issue Number: Close #xxx
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note