client: enable router client by default #10105
Merged
+26
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
ti-chi-bot
bot
added
the
size/XS
ti-chi-bot
bot
added
size/S
bufferflies
approved these changes
Dec 23, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
JmPotato
reviewed
Dec 23, 2025
| // If resp is nil but no error was provided, it means an abnormal situation occurred | ||
| // (e.g., timeout, connection issue). We should pass an error to indicate this. | ||
| if resp == nil { | ||
| req.tryDone(errs.ErrClientRouterConnectionTimeout) |
Member
There was a problem hiding this comment.
Will this error be vague or misleading?
JmPotato
approved these changes
Jan 4, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, JmPotato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Member
|
/retest |
1 similar comment
Member
Author
|
/retest |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
enable-router-client
branch
from
e8a02cc to
f54d149
Compare
ti-chi-bot
bot
added
size/M
Member
Author
|
This feature is not compatible with the circuit breaker and forwarding under network isolation. /cc @JmPotato |
Member
Author
|
/retest |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10105 +/- ##
==========================================
+ Coverage 78.38% 78.40% +0.01%
==========================================
Files 518 518
Lines 69476 69479 +3
==========================================
+ Hits 54456 54472 +16
+ Misses 11066 11050 -16
- Partials 3954 3957 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8690
What is changed and how does it work?
Check List
Tests
Release note