-
Notifications
You must be signed in to change notification settings - Fork 135
[EV-6333] Clarify flow log policy fields in datatypes reference #2472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR clarifies the descriptions of flow log policy fields in the datatypes reference documentation for Calico Enterprise and Calico Cloud. The changes improve the technical documentation by clearly explaining the differences between all_policies, enforced_policies, pending_policies, and transit_policies, marking all_policies as deprecated, and providing more precise explanations of when and how each field is populated.
Changes:
- Marked
all_policiesas deprecated with a clear explanation of why it can be misleading - Clarified that
enforced_policiesrepresents actual dataplane-enforced actions fixed at flow start time - Explained
pending_policiesas a simulation showing hypothetical policy evaluation at log generation time - Simplified and clarified the
transit_policiesdescription for Apply On Forward and pre-DNAT scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| calico-enterprise/observability/elastic/flow/datatypes.mdx | Updated policy field descriptions in the flow log datatypes reference table to clarify the purpose and behavior of each policy tracking field |
| calico-cloud/observability/elastic/flow/datatypes.mdx | Applied identical policy field description updates to maintain consistency with Calico Enterprise documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| | `all_policies` | array of keywords | **Deprecated.** This field is a legacy field calculated at flow start time that combines both enforced and staged policies. Because it mixes actual verdicts with simulated ones, it can be misleading and is planned for removal. <br/><br/>**Note:** This field may still appear in logs from older clusters reporting to a newer management cluster. | | ||
| | `enforced_policies` | array of keywords | The policies that were actually enforced on the flow. This list is determined by the dataplane when the flow starts and remains fixed for the flow's lifetime. It represents the concrete actions taken on the traffic. | | ||
| | `pending_policies` | array of keywords | A simulation of what policy evaluation would look like at the time of log generation. It represents a hypothetical restart of the flow where all staged policies are considered active. <br/>This field captures two types of updates: <br/> 1. Changes to active policies made after the flow started. <br/> 2. Staged policies treated as if they were enforced. | | ||
| | `transit_policies` | array of keywords | Policies applied to traffic transiting through the node (Apply On Forward) or during pre-DNAT processing. This field functions like `enforced_policies` but specifically for traffic being forwarded rather than terminating at a local workload. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | `transit_policies` | array of keywords | Policies applied to traffic transiting through the node (Apply On Forward) or during pre-DNAT processing. This field functions like `enforced_policies` but specifically for traffic being forwarded rather than terminating at a local workload. | | |
| | `transit_policies` | array of keywords | Policies applied to traffic transiting through the node (Apply On Forward) or during pre-DNAT processing. This field functions like `enforced_policies` but specifically for traffic being evaluated at the host endpoint. | |
Would this be better? I was not sure about "local workload".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure myself what the correct options is. But 'the host endpoint' is much clearer that 'a local workload' in this line.
|
LGTM. |
edcff81 to
a491102
Compare
|
@ctauchen I've made the last couple of updates based on the comments in the slack thread . I've also backported into CE v3.22 and CC v22.2. Could you do one more check? |

Product Version(s):
Calico Enterprise, Calico Cloud
Issue:
EV-6333
Link to docs preview:
https://deploy-preview-2472--calico-docs-preview-next.netlify.app/calico-enterprise/next/observability/elastic/flow/datatypes
SME review:
DOCS review:
Additional information:
Merge checklist: