Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SSE event with several
data:fields currently triggers one callback per line. A JSON object split across three fields therefore arrives as three strings instead of one object.Feed intact text chunks to Effect's SSE parser and parse JSON after each completed event. Heartbeat detection keeps its line-based handling on the same shared response body, and server
retry:directives leave the existing reconnect policy intact.This follows SSE framing: raw whitespace is preserved, events dispatch on a blank line, and incomplete trailing events are discarded. Effect's existing limit on pending parser state also applies.
The tests retain a passing single-line control and catch three framing regressions on main. All pass with the fix and also verify cancellation when unsubscribing.