Repository navigation
refactor(sched): drop the clustered scheduler abstraction - #790
Closed
atsushi421 wants to merge 1 commit into
Closed
atsushi421 wants to merge 1 commit into
atsushi421 wants to merge 1 commit into
Conversation
3 tasks done
atsushi421
force-pushed
the
refactor/edf-drop-clustered-abstraction
branch
from
November 13, 2026 05:50
943d13e to
0639476
Compare
atsushi421
force-pushed
the
feat/edf-budget-global-wakes
branch
from
November 13, 2026 05:50
9f7658e to
183d771
Compare
romancardenas
force-pushed
the
refactor/edf-drop-clustered-abstraction
branch
from
November 16, 2026 00:20
0639476 to
bdedf52
Compare
After the merge of GEDF into EDF, the EDF scheduler is the only scheduler whose tasks carry a CPU set. The clustered abstraction generalized over a family with one member, and its names called global EDF tasks "clustered". - get_next_task() calls edf::SCHEDULER directly and then tries PRIORITY_LIST[1..]. A compile-time assertion checks that the EDF scheduler is first in PRIORITY_LIST. This replaces is_clustered(), get_num_clustered_schedulers(), and the prefix assertion. - Scheduler::queued_cpu_mask() becomes an inherent method of EDFScheduler, and wake_workers() calls it directly. This removes clustered_queued_cpu_mask(). - ClusteredTask moves into edf.rs as the private QueuedTask, and NUM_CLUSTERED_TASKS_IN_QUEUE becomes NUM_EDF_TASKS_IN_QUEUE. - Comments and the mdbook use EDF terms. The behavior does not change. Signed-off-by: atsushi421 <atsushi.yano.2@tier4.jp>
atsushi421
force-pushed
the
refactor/edf-drop-clustered-abstraction
branch
from
November 17, 2026 07:49
bdedf52 to
1d82487
Compare
atsushi421
changed the base branch from
feat/edf-budget-global-wakes
to
main
November 17, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the clustered scheduler abstraction. It does not change the behavior.
After #787, the EDF scheduler is the only scheduler whose tasks carry a CPU set. The clustered abstraction generalized over a family with one member, and its names called global EDF tasks "clustered".
Changes:
get_next_task()callsedf::SCHEDULERdirectly and then triesPRIORITY_LIST[1..]. A compile-time assertion checks that the EDF scheduler is first inPRIORITY_LIST. This replacesSchedulerType::is_clustered(),get_num_clustered_schedulers(), and the prefix assertion.Scheduler::queued_cpu_mask()becomes an inherent method ofEDFScheduler, andwake_workers()calls it directly. This removesclustered_queued_cpu_mask()and the "Implementing a clustered scheduler" section of the trait doc.ClusteredTaskmoves intoscheduler/edf.rsas the privateQueuedTask, andNUM_CLUSTERED_TASKS_IN_QUEUEbecomesNUM_EDF_TASKS_IN_QUEUE.scheduler::edfbecomespub(super), likescheduler::panicked, so thatwake_workers()intask.rscan calledf::SCHEDULER.queued_cpu_mask().Related links
How was this PR tested?
scripts/ci.shpasses on my machine.aarch64_virt, 4 CPUs),test_edflogs no[FAIL], and every node oftest_dagruns. Every task oftest_multi_prioritized_schedulerstarts and finishes. No test panics, and the logs match those of main.Notes for reviewers
#789 was closed, so this PR now targets main.