nested_fit_resamples() refuses a metric set that does not suit the model's mode - #132
Merged
Merged
Conversation
…ted to nested_fit_resamples()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nested_fit_resamples()now stops with an error of classnestedtune_metrics_modebefore any fold runs when the metric set does not suit the model's mode (for example, a classification metric on a regression model). Before, every fold ran and failed, and the call only warned.nested_workflow_map()makes the same refusal in its pre-check for workflows it routes tonested_fit_resamples(), before any workflow runs.nested_loop()runs the mode check for every tuner and keeps the selecting metric's name only for a tuner that selects.tests/testthat/test-selection-metric.R.Local:
devtools::test()passes (11503 expectations),devtools::check()gives 0 errors, 0 warnings, 0 notes.