Name the notify job, and finish the rename - #315
Merged
Conversation
The notify job had no `name`, so it displayed as "notify / notify" while its sibling showed "Notify titanium-docs (legacy)". It now reads "Notify titaniumsdk.com", which also makes the two destinations legible at a glance in the Actions list. The rename to titaniumsdk.com also missed six comment references: that change replaced `tidev/titanium-www` and left bare `titanium-www` behind, leaving one comment reading "titaniumsdk.com. The dispatch lives in titanium-www".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to
regen-docs.yml.The
notifyjob had no nameIt displayed as
notify / notifywhile its sibling showedNotify titanium-docs (legacy). It now readsNotify titaniumsdk.com, so the two dispatch destinations are distinguishable at a glance in the Actions list.The rename was incomplete
The rename PR replaced
tidev/titanium-wwwbut left baretitanium-wwwin six comments — including one that read "titaniumsdk.com. The dispatch lives in titanium-www". Cosmetic, but actively misleading. Fixed here.No behaviour change: the
uses:reference, the triggers, and the legacytitanium-docsdispatch are all untouched.